refactor Dir.tmpdir - make it more idiomatic and functional#16
Merged
nobu merged 1 commit intoruby:masterfrom Oct 25, 2022
Merged
refactor Dir.tmpdir - make it more idiomatic and functional#16nobu merged 1 commit intoruby:masterfrom
Dir.tmpdir - make it more idiomatic and functional#16nobu merged 1 commit intoruby:masterfrom
Conversation
Use `Enumerable#find` to iterate over the candidates, not `Enumerable.each`. (this makes the code more functional, and - IMO - slightly more idiomatic, as it avoids setting the "global" (by which I mean: non-local) `tmp` variable from inside the block)
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Enumerable#findto iterate over the candidate directories, notEnumerable#each.This gives the code a more functional "feel", and also makes it - IMO - slightly more idiomatic, as it avoids setting the "global" (by which I mean: non-local)
tmpvariable from inside the block.